Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS first connection #156

Merged
merged 14 commits into from
Oct 17, 2023
Merged

TLS first connection #156

merged 14 commits into from
Oct 17, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Oct 16, 2023 •
edited
Loading

Currently only supported in server PR nats-io/nats-server#4642

  • Automated test once PR merged

@mtmk mtmk requested review from caleblloyd and Jarema October 16, 2023 10:45
caleblloyd
caleblloyd reviewed Oct 16, 2023
View reviewed changes
src/NATS.Client.Core/NatsConnection.cs Outdated Show resolved Hide resolved
src/NATS.Client.Core/NatsTlsOpts.cs Outdated Show resolved Hide resolved
src/NATS.Client.Core/NatsTlsOpts.cs Outdated Show resolved Hide resolved
src/NATS.Client.Core/NatsTlsOpts.cs Outdated Show resolved Hide resolved
mtmk added 3 commits October 17, 2023 11:30
@mtmk
Don't fix TLS host on initial connection
49d1264 
Fixing TLS host relies on the last connected seed host
which isn't available on initial connection.
@mtmk
Use local for TLS host fix
9c6cc4f
@mtmk
Reverted debug value in test
6eaa13a
caleblloyd
caleblloyd approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 4100569 into main Oct 17, 2023
9 checks passed
@mtmk mtmk deleted the tls-first branch October 17, 2023 13:18
mtmk added a commit that referenced this pull request Oct 20, 2023
@mtmk
Release prep 2.0.0-alpha.5
12c07f0 
* Initial Object Store implementation (#150)
* TLS first connection (#156)
* Consume clean exit fixes (#161)
* Add NatsMemoryOwner (#162)
@mtmk mtmk mentioned this pull request Oct 20, 2023
Merged
mtmk added a commit that referenced this pull request Oct 20, 2023
@mtmk
Release prep 2.0.0-alpha.5 (#163)
07ef3bd 
* Release prep 2.0.0-alpha.5

* Initial Object Store implementation (#150)
* TLS first connection (#156)
* Consume clean exit fixes (#161)
* Add NatsMemoryOwner (#162)

* Pack object store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtmk @caleblloyd